Skip to content

[tea-merge] Remove attribution#25223

Merged
weswigham merged 2 commits intoDefinitelyTyped:masterfrom
pluma:disown-tea-merge
Apr 25, 2018
Merged

[tea-merge] Remove attribution#25223
weswigham merged 2 commits intoDefinitelyTyped:masterfrom
pluma:disown-tea-merge

Conversation

@pluma
Copy link
Copy Markdown
Collaborator

@pluma pluma commented Apr 23, 2018

The author of these typings (@mihhail-lapushkin) has asked for me to remove his attribution on his behalf because he is no longer actively using TypeScript. See #25177 (comment) for his authorisation of this change.

This PR only removes the attribution, it doesn't make any other changes.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 23, 2018

@pluma Thank you for submitting this PR!

Because this PR doesn't have any code reviewers, a DefinitelyTyped maintainer will be reviewing it in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot typescript-bot added Unowned This PR touches a package that doesn't have any listed owners. The Travis CI build failed labels Apr 23, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 23, 2018

@pluma The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@pluma
Copy link
Copy Markdown
Collaborator Author

pluma commented Apr 23, 2018

@RyanCavanaugh I'm not sure how to fix the lint error. The linter complains because there's no attribution but that's the point of the PR. Is there a default for unowned typings or do I have to adopt it?

@RyanCavanaugh
Copy link
Copy Markdown
Member

@pluma We need the header line but I think you can write

Definitions by: No one <[email protected]>

and everything should work as expected

@pluma
Copy link
Copy Markdown
Collaborator Author

pluma commented Apr 23, 2018

That seems to have worked.

@weswigham weswigham merged commit bd16c73 into DefinitelyTyped:master Apr 25, 2018
@pluma pluma deleted the disown-tea-merge branch April 25, 2018 00:12
@pluma
Copy link
Copy Markdown
Collaborator Author

pluma commented Apr 25, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unowned This PR touches a package that doesn't have any listed owners.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants