[daterangepicker] Add missing isCustomDate into Settings type#25042
[daterangepicker] Add missing isCustomDate into Settings type#25042RyanCavanaugh merged 1 commit into
Conversation
|
@jacoporicare Thank you for submitting this PR! 🔔 @SirMartin @smasala @nertzy - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
|
🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ Congratulations on your first DefinitelyTyped contribution! 🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ |
|
@RyanCavanaugh Thank you a lot! 🤝🥂 Actually my first contribution to OSS ever. 😊 |
|
@RyanCavanaugh Hello Ryan, may I have a quick question - I fixed this typing because I'm using another typings: react-bootstrap-daterangepicker and it's using this typing as a base type. Do I have to do something (open a PR for example) so it's updated on NPM as well? Thank you! |
|
@jacoporicare no, types are automatically published to NPM |
4 participants
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.