Skip to content

Add missing argument for Screen (react-native-navigation)#25022

Merged
RyanCavanaugh merged 2 commits into
DefinitelyTyped:masterfrom
henrikra:master
Apr 16, 2018
Merged

Add missing argument for Screen (react-native-navigation)#25022
RyanCavanaugh merged 2 commits into
DefinitelyTyped:masterfrom
henrikra:master

Conversation

@henrikra

Copy link
Copy Markdown
Contributor
  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

React-native-navigation has prop overrideBackPress which can be passed as argument when for example pushing new screen. The purpose of the argument is to control what happens when user presses back button on Android. More info on this here: https://github.com/wix/react-native-navigation/issues/250

@typescript-bot

typescript-bot commented Apr 16, 2018

Copy link
Copy Markdown
Contributor

@henrikra Thank you for submitting this PR!

🔔 @egorshulga - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit 4baec53 into DefinitelyTyped:master Apr 16, 2018
@RyanCavanaugh

Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

@henrikra

Copy link
Copy Markdown
Contributor Author

Epic 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants