Skip to content

[react-map-gl]: add more types and narrow down others#25007

Merged
RyanCavanaugh merged 1 commit into
DefinitelyTyped:masterfrom
fnberta:react-map-gl-updates
Apr 16, 2018
Merged

[react-map-gl]: add more types and narrow down others#25007
RyanCavanaugh merged 1 commit into
DefinitelyTyped:masterfrom
fnberta:react-map-gl-updates

Conversation

@fnberta

@fnberta fnberta commented Apr 15, 2018

Copy link
Copy Markdown
Contributor

Narrowed down some types and added some more. Still not 100% coverage, but we're getting there :).

@typescript-bot

typescript-bot commented Apr 15, 2018

Copy link
Copy Markdown
Contributor

@fnberta Thank you for submitting this PR!

🔔 @rimig - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@rimig rimig left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, ltgm, thanks for doing this.

@typescript-bot

Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit c78f461 into DefinitelyTyped:master Apr 16, 2018
@RyanCavanaugh

Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants