Swiper: Implement typings for v4.2 of http://idangero.us/swiper#24898
Conversation
typescript-bot
added
New Definition
|
@ematseruk Thank you for submitting this PR! Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
|
@sgaliano can you please review this change. |
| // Type definitions for Swiper 4.2 | ||
| // Project: https://github.com/nolimits4web/Swiper | ||
| // Definitions by: Sebastián Galiano <https://github.com/sgaliano>, Luca Trazzi <https://github.com/lucax88x> | ||
| // Definitions by: Eugene Matseruk <https://github.com/ematseruk> |
There was a problem hiding this comment.
please do not change the owner of the package. add your name to the list.
typescript-bot
added
the
Revision needed
|
@ematseruk One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
typescript-bot
removed
the
Revision needed
|
🔔 @mhegazy - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate? |
- Move typings for v3 to the separate v3 folder - Implement typings for v4.2 - Implement tests for typings
mhegazy
dismissed
their stale review
No more comments from me, waiting on @sgaliano to review.
|
As soon I am on a pc I surely can |
|
@mhegazy For me it's ok, but I cannot approve myself as I'm not a reviewer |
|
🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ Congratulations on your first DefinitelyTyped contribution! 🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ |
5 participants
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.