Skip to content

Add MultiHook and _pluginCompat to Tapable #24527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 6 commits into from
Mar 27, 2018
Merged

Add MultiHook and _pluginCompat to Tapable #24527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e2d5356
Fix Tapable types
Mar 26, 2018
f6c1603
Merge branch 'master' of github.com:DefinitelyTyped/DefinitelyTyped i…
Mar 27, 2018
a3cc0cb
..
Mar 27, 2018
d149776
Clean up
Mar 27, 2018
d791caa
Undo instance member change
Mar 27, 2018
02648bb
Add constructor to Hookmap
Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions types/tapable/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ export declare abstract class Tapable {
[propName: string]: Tapable.Handler[]
}

/** @deprecated Private internals. Do not use directly */
_pluginCompat: Hook;

/**
* @deprecated Tapable.plugin is deprecated. Use new API on `.hooks` instead
* Register plugin(s)
Expand Down Expand Up @@ -275,7 +278,9 @@ export class HookInterceptor {
context: boolean;
}

/** A HookMap is a helper class for a Map with Hooks */
export class HookMap<T1 = any, T2 = any, T3 = any> {
constructor(fn: () => Hook);
get: (key: any) => Hook<T1, T2, T3> | undefined;
for: (key: any) => Hook<T1, T2, T3>;
tap: (key: any, name: string | Tap, fn: (arg1: T1, arg2: T2, arg3: T3, ...args: any[]) => any) => void;
Expand All @@ -287,3 +292,16 @@ export class HookMap<T1 = any, T2 = any, T3 = any> {
export class HookMapInterceptor<T1 = any, T2 = any, T3 = any> {
factory: (key: any, hook: Hook<T1, T2, T3>) => Hook<T1, T2, T3>;
}

/**
* A helper Hook-like class to redirect taps to multiple other hooks
*
* ```
* const { MultiHook } = require("tapable");
*
* this.hooks.allHooks = new MultiHook([this.hooks.hookA, this.hooks.hookB]);
* ```
*/
export class MultiHook {
constructor(hooks: Hook[])
}
4 changes: 3 additions & 1 deletion types/tapable/tapable-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {Tapable} from "tapable";
import {Tapable, MultiHook, SyncHook} from "tapable";

class DllPlugin {
apply(compiler: Compiler) {
Expand Down Expand Up @@ -43,3 +43,5 @@ compiler.applyPluginsAsyncWaterfall('doSomething', 'a', callback);
compiler.applyPluginsParallel('doSomething', 'a', 'b');
compiler.applyPluginsParallelBailResult('doSomething', 'a', 'b');
compiler.applyPluginsParallelBailResult1('doSomething', 'a', callback);

const multi = new MultiHook([new SyncHook(['hi'])]);