Skip to content

Add deprecated process.bindings to node.js #24521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mohsen1 wants to merge 5 commits into from
Closed

Add deprecated process.bindings to node.js #24521

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e27a237
Add deprecated process.binding
mohsen1 Mar 25, 2018
a51c62a
Merge branch 'master' of github.com:DefinitelyTyped/DefinitelyTyped i…
Mar 27, 2018
3601524
Merge branch 'master' of github.com:DefinitelyTyped/DefinitelyTyped i…
Mar 28, 2018
033753b
Update index.d.ts
mohsen1 Mar 29, 2018
8c30c55
Update index.d.ts
mohsen1 Mar 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions types/node/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,12 @@ declare namespace NodeJS {
stderr: WriteStream;
stdin: ReadStream;
openStdin(): Socket;
/**
* @deprecated
* Using process.binding() in general should be avoided.
* The type checking methods in particular can be replaced by using util.types.

@Flarna Flarna Mar 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me what this comment should tell me. What related to process.binding should be replaced by util.types?

*/
binding: { [key: string]: string; };

@Flarna Flarna Mar 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be binding(internalModule: string): any;.

argv: string[];
argv0: string;
execArgv: string[];
Expand Down