Skip to content

Create correct major version for webpack-dev-middleware (fixes bugs from #22267)#22661

Merged
mhegazy merged 2 commits intoDefinitelyTyped:masterfrom
donaldpipowitch:webpack-dev-middleware-v2
Jan 4, 2018
Merged

Create correct major version for webpack-dev-middleware (fixes bugs from #22267)#22661
mhegazy merged 2 commits intoDefinitelyTyped:masterfrom
donaldpipowitch:webpack-dev-middleware-v2

Conversation

@donaldpipowitch
Copy link
Copy Markdown
Contributor

@donaldpipowitch donaldpipowitch commented Jan 4, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Updated webpack-dev-middleware to v2 #22267
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

Sadly there was a bug in the CI (#22267 (comment)) which didn't catch the errors of my incorrect pull request to include webpack-dev-middleware v2 changes (#22267). This PR tries to fix my older PR.

(Note: First time I created a new major version for lib here. Hope I checked everything.)

@donaldpipowitch
Copy link
Copy Markdown
Contributor Author

donaldpipowitch commented Jan 4, 2018

Travis seems to have problems :(

network request to https://registry.npmjs.org/typescript failed, reason: connect ETIMEDOUT 151.101.200.162:443

...

The command "eval npm install " failed 3 times

@mhegazy mhegazy merged commit 62864b2 into DefinitelyTyped:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants