@types/node ClusterSetupMasterSettings to ClusterSettings#22647
Merged
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom Jan 3, 2018
progral:patch-1
Merged
@types/node ClusterSetupMasterSettings to ClusterSettings#22647mhegazy merged 1 commit intoDefinitelyTyped:masterfrom progral:patch-1
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
progral:patch-1
Conversation
According to official docs the settings for setupMaster settings are just the ClusterSettings. There is an ClusterSettings interface already but setupMaster function parameters refered to incomplete and unnecessary ClusterSetupMasterSettings. I deleted the ClusterSetupMasterSettings interface and refer to the existing ClusterSettings which are correct. https://nodejs.org/docs/latest-v8.x/api/cluster.html#cluster_cluster_setupmaster_settings
Contributor
|
@xipheCom The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Contributor
|
error in restify seems unrelated to this change. |
Contributor
8 tasks
KSXGitHub
pushed a commit
to KSXGitHub/DefinitelyTyped
that referenced
this pull request
May 12, 2018
According to official docs the settings for setupMaster settings are just the ClusterSettings. There is an ClusterSettings interface already but setupMaster function parameters refered to incomplete and unnecessary ClusterSetupMasterSettings. I deleted the ClusterSetupMasterSettings interface and refer to the existing ClusterSettings which are correct. https://nodejs.org/docs/latest-v8.x/api/cluster.html#cluster_cluster_setupmaster_settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to official docs the settings for setupMaster settings are just the ClusterSettings.
There is an ClusterSettings interface already but setupMaster function parameters refered to incomplete and unnecessary ClusterSetupMasterSettings. I deleted the ClusterSetupMasterSettings interface and refer to the existing ClusterSettings which are correct.
https://nodejs.org/docs/latest-v8.x/api/cluster.html#cluster_cluster_setupmaster_settings
Please fill in this template.
npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
dts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.If removing a declaration:
notNeededPackages.json.