dockerode: Fix ContainerInspectInfo according to Docker REST API documentation.#22598
Merged
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom Jan 3, 2018
binaris:master
Merged
dockerode: Fix ContainerInspectInfo according to Docker REST API documentation.#22598mhegazy merged 1 commit intoDefinitelyTyped:masterfrom binaris:master
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
binaris:master
Conversation
The Ports field is a map of string to _array_ of Ip/Port objects, as you can see in the docs: https://docs.docker.com/engine/api/v1.32/#operation/ContainerInspect As a result of this error type checks are not being run. e.g. Doing `container.inspect().NetworkSettings.Ports['test'][0].BadField` will compile without error, despite `BadField` to existing in the interface.
lavie
changed the title
Contributor
Author
|
(kudos on the friendly and to-the-point pull-request to-do injection. it was a pleasure to follow) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ports field is a map of string to array of Ip/Port objects, as you
can see in the docs: https://docs.docker.com/engine/api/v1.32/#operation/ContainerInspect
As a result of this error type checks are not being run. e.g. Doing
container.inspect().NetworkSettings.Ports['test'][0].BadFieldwillcompile without error, despite
BadFieldto existing in the interface.Please fill in this template.
npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition: