[adone] fix builderror because of incompatible definition of duplex.end()#22569
Merged
mhegazy merged 3 commits intoDefinitelyTyped:masterfrom Jan 2, 2018
Flarna:adone_fix_end
Merged
[adone] fix builderror because of incompatible definition of duplex.end()#22569mhegazy merged 3 commits intoDefinitelyTyped:masterfrom Flarna:adone_fix_end
mhegazy merged 3 commits intoDefinitelyTyped:masterfrom
Flarna:adone_fix_end
Conversation
Contributor
|
@Flarna The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Contributor
Author
|
ping @s0m3on3 @maxveres |
s0m3on3
approved these changes
Jan 2, 2018
Contributor
|
A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run lint package-name(ortscif notslint.jsonis present).tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.I got a build error in another PR because end() defined in adone doesn't match to
end()defined in nodejs duplex stream which is used as base class:Most likely caused by #22077.