[@types/reactstrap] Adding carousel components, removing Tether#22512
[@types/reactstrap] Adding carousel components, removing Tether#22512mhegazy merged 3 commits intoDefinitelyTyped:masterfrom
Conversation
KurtPreston
force-pushed
the
reactstrap
branch
from
41c5016 to
1ac8529
Compare
|
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
typescript-bot
added
the
Unmerged
| export { default as Table, TableProps } from './lib/Table'; | ||
| export { default as TabPane, TabPaneProps } from './lib/TabPane'; | ||
| export { default as Tag, TagProps } from './lib/Tag'; | ||
| export { default as TetherContent, TetherContentProps } from './lib/TetherContent'; |
There was a problem hiding this comment.
removal of tether is a breaking change in v 5-alpha.
First, the version should be updated to reflect this, see https://github.com/DefinitelyTyped/DefinitelyTyped#i-want-to-update-a-package-to-a-new-major-version since it is a major version.
Second, consider nod making the breaking change untill a stable release is available.
typescript-bot
added
Revision needed
|
@KurtPreston One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@KurtPreston Could you also add |
4 participants
npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.