Skip to content

webgme: Provides its own types#22394

Merged
1 commit merged intomasterfrom
not-needed-webgme
Jan 2, 2018
Merged

webgme: Provides its own types#22394
1 commit merged intomasterfrom
not-needed-webgme

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 20, 2017

This will deprecate @types/webgme in favor of just webgme. CC @phreed

@typescript-bot
Copy link
Copy Markdown
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Dec 27, 2017
@phreed
Copy link
Copy Markdown
Contributor

phreed commented Dec 28, 2017

Yes, the typings are now included in the webgme project itself so there is no longer a need for it in DefinitelyTyped.

@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. and removed Unmerged The author did not merge the PR when it was ready. labels Dec 29, 2017
@typescript-bot
Copy link
Copy Markdown
Contributor

@Andy-MS Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@ghost ghost force-pushed the not-needed-webgme branch from 5abec03 to 2d8dc84 Compare January 2, 2018 16:55
@ghost ghost merged commit 212d4b8 into master Jan 2, 2018
@ghost ghost deleted the not-needed-webgme branch January 2, 2018 17:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants