[node] Support passing callback-only in writable.end()#22077
[node] Support passing callback-only in writable.end()#22077aozgaa merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
types/node/index.d.ts to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @DeividasBakanas @kjin @alvis @OliverJAsh @eps1lon @Hannes-Magnusson-CK Microsoft TypeScript (account can't be detected)). Could you review this PR? types/node/v0/index.d.ts to authors (@DefinitelyTyped/DefinitelyTyped Microsoft TypeScript (account can't be detected)). Could you review this PR? types/node/v4/index.d.ts to authors (@DefinitelyTyped/DefinitelyTyped @eps1lon Microsoft TypeScript (account can't be detected)). Could you review this PR? types/node/v6/index.d.ts to authors (@DefinitelyTyped/DefinitelyTyped @WilcoBakker @inlined @eps1lon Microsoft TypeScript (account can't be detected)). Could you review this PR? types/node/v7/index.d.ts to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @tellnes @WilcoBakker @eps1lon Microsoft TypeScript (account can't be detected)). Could you review this PR? |
typescript-bot
added
the
Popular package
|
Shouldn't the |
|
A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
typescript-bot
added
the
Unmerged
|
@Flarna Done. |
typescript-bot
removed
the
Unmerged
typescript-bot
added
Author Approved
Other Approved
[node] Support passing callback-only in writable.end()
5 participants
Please fill in this template.
npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.In case it's unclear, this is intended to support code of the form
This API supports leaving off the chunk argument in every version of the API I've looked at that supports the callback function at all, from
https://nodejs.org/docs/latest-v0.10.x/api/stream.html#stream_writable_end_chunk_encoding_callback
to
https://nodejs.org/dist/latest-v9.x/docs/api/stream.html#stream_writable_end_chunk_encoding_callback