node: global tslint:disable is forbidden#21768
node: global tslint:disable is forbidden#21768eps1lon wants to merge 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
types/node/index.d.ts to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @DeividasBakanas @kjin @alvis @OliverJAsh Microsoft TypeScript (account can't be detected)). Could you review this PR? |
|
This did not pass travis checks. It threw an error but still returned with exit code 0.
Edit: |
|
Closing and reopening this to trigger travis to rerun since microsoft/dtslint#91 was fixed. |
|
This PR has been open and unchanged 5 days without signoff or complaint. This will be merged by a maintainer soon if there are no objections. |
|
@eps1lon Please address the merge conflict. |
|
This landed via d251c64 |
Please fill in this template.
npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
As of Error on 'ts-ignore' or 'tslint:disable' comments microsoft/dtslint#89 global
tslint-disableis forbidden. This adresses node export http2 constants in standard way #21764tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.