types/node/index.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @DeividasBakanas @kjin @alvis @OliverJAsh @eps1lon Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

I don't understand the failed tslint on travis-ci. I get this locally:

C:\Users\camer\ts\DefinitelyTyped [http2-constants ≡]> npm run lint node

> [email protected] lint C:\Users\camer\ts\DefinitelyTyped
> dtslint types "node"

@ctaggart Please fix the failures indicated in the Travis CI log.

I checked out your PR and run the linter with a fresh npm install and npm install typescrpt and got the same errors as travis got.

The error however has nothing to do with the PR. The behavior was added with microsoft/dtslint#89. There are currently however 65 packages which use tslint:disable.

Given that the errors have nothing to do with the PR, this looks good to me 👍

@eps1lon, microsoft/dtslint#89 is fixed now. What is the easiest way to get this passing the tests now?

#21768 should fix this. So I think you should/can wait for that one to be merged.

After that I'm not so sure. Maybe it's enough to rebase your pr with master to trigger a rerun or if you have to reopen it for travis to recognize the change.

Triggering a new CI build.

The build passes now that the tslint:disable stuff was sorted out and merged to master.

Approved by a listed owner. PR ready to merge pending express review by a maintainer.