Reactstrap: Introduce typings for v5.0#20696
Merged
sheetalkamat merged 2 commits intoDefinitelyTyped:masterfrom Oct 28, 2017
Merged
Reactstrap: Introduce typings for v5.0#20696sheetalkamat merged 2 commits intoDefinitelyTyped:masterfrom
sheetalkamat merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
Contributor
Author
|
@alihammad @mfal @danilobjr @fabiopaiva Could you review? |
Contributor
|
This PR has been open and unchanged 5 days without signoff or complaint. This will be merged by a maintainer soon if there are no objections. |
Contributor
|
@b-szypelow Do we need to keep the v4 folder around? You could always use a older version if you're still using reactstrap v4. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reactstrap v5.0 (currently in alpha) introduced some breaking changes like renaming all
getReftoinnerRef. This PR is a first step to support this major release separately to 4.x.npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.