Skip to content

Reactstrap: Introduce typings for v5.0#20696

Merged
sheetalkamat merged 2 commits intoDefinitelyTyped:masterfrom
b-szypelow:reactstrap5
Oct 28, 2017
Merged

Reactstrap: Introduce typings for v5.0#20696
sheetalkamat merged 2 commits intoDefinitelyTyped:masterfrom
b-szypelow:reactstrap5

Conversation

@b-szypelow
Copy link
Copy Markdown
Contributor

@b-szypelow b-szypelow commented Oct 18, 2017

Reactstrap v5.0 (currently in alpha) introduced some breaking changes like renaming all getRef to innerRef. This PR is a first step to support this major release separately to 4.x.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <input> reference for Input  reactstrap/reactstrap#583 (comment)
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@b-szypelow
Copy link
Copy Markdown
Contributor Author

@alihammad @mfal @danilobjr @fabiopaiva Could you review?

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Oct 18, 2017
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Oct 23, 2017
@typescript-bot
Copy link
Copy Markdown
Contributor

This PR has been open and unchanged 5 days without signoff or complaint. This will be merged by a maintainer soon if there are no objections.

@sheetalkamat sheetalkamat merged commit f7f81bc into DefinitelyTyped:master Oct 28, 2017
@Sprogel
Copy link
Copy Markdown
Contributor

Sprogel commented Nov 7, 2017

@b-szypelow Do we need to keep the v4 folder around? You could always use a older version if you're still using reactstrap v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Definition This PR creates a new definition package. Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants