Skip to content

Add react-dom/node-stream#18493

Merged
sheetalkamat merged 1 commit intoDefinitelyTyped:masterfrom
edgesite:master
Aug 2, 2017
Merged

Add react-dom/node-stream#18493
sheetalkamat merged 1 commit intoDefinitelyTyped:masterfrom
edgesite:master

Conversation

@edgesite
Copy link
Copy Markdown
Contributor

@edgesite edgesite commented Jul 29, 2017

Add https://github.com/facebook/react/blob/master/src/node_modules/react-dom/node-stream.js ( export https://github.com/facebook/react/blob/master/src/renderers/dom/ReactDOMNodeStreamRenderer.js)

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, and strictNullChecks set to true.

@dt-bot
Copy link
Copy Markdown
Member

dt-bot commented Jul 29, 2017

@typescript-bot typescript-bot added the Unowned This PR touches a package that doesn't have any listed owners. label Jul 29, 2017
@sheetalkamat
Copy link
Copy Markdown
Contributor

@MartynasZilinskas can you please review this. Thanks

Copy link
Copy Markdown
Collaborator

@MartynasZilinskas MartynasZilinskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 👍

@typescript-bot
Copy link
Copy Markdown
Contributor

Approved by third party. PR appears ready to merge pending review by a maintainer.

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Merge:LGTM labels Aug 2, 2017
@sheetalkamat sheetalkamat merged commit 692b49b into DefinitelyTyped:master Aug 2, 2017
milosdanilov pushed a commit to milosdanilov/DefinitelyTyped that referenced this pull request Aug 5, 2017
Copy link
Copy Markdown

@teraton teraton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR brings with it the types/node typings file and it breaks setTimeout and other typical functions in environments where node is not used.

This for example forces the type setTimeout to nodejs.timer which is definately not what we want on the fronend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Other Approved This PR was reviewed and signed-off by a community member. Unowned This PR touches a package that doesn't have any listed owners.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants