Add react-dom/node-stream#18493
Merged
sheetalkamat merged 1 commit intoDefinitelyTyped:masterfrom Aug 2, 2017
edgesite:master
Merged
Add react-dom/node-stream#18493sheetalkamat merged 1 commit intoDefinitelyTyped:masterfrom edgesite:master
sheetalkamat merged 1 commit intoDefinitelyTyped:masterfrom
edgesite:master
Conversation
Member
|
types/react-dom/node-stream/index.d.ts Checklist
|
Contributor
|
@MartynasZilinskas can you please review this. Thanks |
MartynasZilinskas
approved these changes
Aug 2, 2017
Contributor
|
Approved by third party. PR appears ready to merge pending review by a maintainer. |
milosdanilov
pushed a commit
to milosdanilov/DefinitelyTyped
that referenced
this pull request
Aug 5, 2017
teraton
reviewed
Aug 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add https://github.com/facebook/react/blob/master/src/node_modules/react-dom/node-stream.js ( export https://github.com/facebook/react/blob/master/src/renderers/dom/ReactDOMNodeStreamRenderer.js)
npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
dts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis, andstrictNullChecksset totrue.