types/node/index.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @robdesideri @tellnes @WilcoBakker Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

Checklist

• pass the Travis CI test?

types/node/v7/index.d.ts

Checklist

• is correct naming convention?
  • https://www.npmjs.com/package/node
  • http://bower.io/search/?q=node
  • others?
• has a test file? (node-tests.ts or node-tests.tsx)
• pass the Travis CI test?

See #16860.
This branch doesn't seem to make any type changes to node/index.d.ts.

@Andy-MS Now users can add features to declaration for Node.js v7 which doesn't exist in Node.js v7 runtime.

There are several problems:

• Code will be compiled with such definition, but will fail at runtime.
• People can start to use declaration for Node.js v7 with Node.js v8 runtime. After that, removing anything related to Node.js v8 from v7 definition potentially can brake many modules.

If separated issue (#16860) for Node.js v8 exists, why pull request with util.promisify was merged?

@ikokostya This solution doesn't seem solve broken runtime anyway cause there are plenty modules that just referencing the latest DT/node/index.d.ts version in their dependencies meaning moving index.d.ts to separate folder won't help. Though I like idea to keep separate versions.

So @yuit @Andy-MS what we wait here? Could you provide TODO list of necessary changes for Node.js 8 #16860 (comment)?

@Andy-MS to close the loop. I don't see a reason not to merge this. It'll keep people from adding v8 features to v7 typings. Any objections?

It seems this has not been published to @types/node npm package yet? The latest version of that package is 7.0.31

@magnushiie check again, it's up

Thanks!