[@types/node] Test mock implementations should use the typed function `F` #68439

Unanswered

gorankarlic asked this question in Issues with a @types package

gorankarlic
Feb 2, 2024

Node test mock implementations should use the typed F instead of untyped Function:

DefinitelyTyped/types/node/test.d.ts

Line 965 in fcefc87

mockImplementation(implementation: Function): void;

mockImplementation(implementation: F): void;

DefinitelyTyped/types/node/test.d.ts

Line 1002 in fcefc87

mockImplementationOnce(implementation: Function, onCall?: number): void;

mockImplementationOnce(implementation: F, onCall?: number): void;

This would be in line with the recorded calls which are already properly typed

DefinitelyTyped/types/node/test.d.ts

Line 926 in fcefc87

readonly calls: Array<MockFunctionCall<F>>;

Replies: 1 comment

typescript-bot
Feb 2, 2024
Collaborator

Thanks for the discussion about "node", some useful links for everyone:

Pinging the DT module owners: @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky.

0 replies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment