[@types/react] version 17.0.56 introduced breaking change
#64999
-
|
See original issue to learn more microsoft/fluentui#27425 |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 2 replies
-
|
Thanks for the discussion about "react", some useful links for everyone: Pinging the DT module owners: @johnnyreilly, @bbenezech, @pzavolinsky, @ericanderson, @DovydasNavickas, @theruther4d, @guilhermehubner, @ferdaber, @jrakotoharisoa, @pascaloliv, @Hotell, @franklixuefei, @Jessidhia, @saranshkataria, @lukyth, @eps1lon, @zieka, @dancerphil, @dimitropoulos, @disjukr, @vhfmag, @hellatan, @priyanshurav, @Semigradsky. |
Beta Was this translation helpful? Give feedback.
-
|
Could you trim this down to just using |
Beta Was this translation helpful? Give feedback.
-
|
It sounds like you have an interface that extended The solution is to omit that prop e.g. -interface TooltipProps extendsHTMLAttributes {
+interface TooltipProps extends Omit<HTMLAttributes, 'content'> {
content?: Element | Element[] | string | undefined
}These are the sort of breaking changes we and any other type declaration has to make occasionally. Otherwise every change would need to be a SemVer major because type changes are generally backwards incompatible. |
Beta Was this translation helpful? Give feedback.
-
|
right I also thought about that workaround. but still it's a breaking change. I understand how brittle DT type changes can be, but it would be great to do some sort of announcement if you're aware of those in advance. thx |
Beta Was this translation helpful? Give feedback.
-
Any types change. This isn't specific to DT.
Changes are released immediately. It's hard to imagine what might break and how to migrate. For this one I could've probably thought about it and added the proper fix to the PR description. But generally, we can't cover every usage. It would be awesome to get a changelog in the DT types. So if you want to champion that change, I'm happy to assist. |
Beta Was this translation helpful? Give feedback.
It sounds like you have an interface that extended
HTMLAttributesbut also declared RDFa props. That declaration is not compatible with the RDFa prop.The solution is to omit that prop e.g.
These are the sort of breaking changes we and any other type declaration has to make occasionally. Otherwise every change would need to be a SemVer major because type changes are generally backwards incompatible.