remove extra overload

sandersn · sandersn · commit f528dfc0012a · 2024-07-18T11:12:09.000-07:00
diff --git a/types/node/v16/module.d.ts b/types/node/v16/module.d.ts
@@ -204,19 +204,6 @@ declare module "module" {
     global {
         interface ImportMeta extends ImportMetaDOMCompat {
             url: string;
-            /**
-             * @experimental
-             * This feature is only available with the `--experimental-import-meta-resolve`
-             * command flag enabled.
-             *
-             * Provides a module-relative resolution function scoped to each module, returning
-             * the URL string.
-             *
-             * @param specified The module specifier to resolve relative to `parent`.
-             * @param parent The absolute parent module URL to resolve from. If none
-             * is specified, the value of `import.meta.url` is used as the default.
-             */
-            resolve(specified: string, parent?: string | URL): Promise<string>;
         }
     }
     export = Module;
diff --git a/types/node/v16/test/module-dom.ts b/types/node/v16/test/module-dom.ts
@@ -5,5 +5,5 @@ import { URL } from "node:url";
     const importmeta: ImportMeta = {} as any; // Fake because we cannot really access the true `import.meta` with the current build target
     importmeta.url; // $ExpectType string
     importmeta.resolve!("local"); // $ExpectType Promise<string> || string
-    importmeta.resolve!("local"); // $ExpectType Promise<string> || string
 }
+
diff --git a/types/node/v16/test/module-non-dom.ts b/types/node/v16/test/module-non-dom.ts
@@ -4,6 +4,7 @@ import { URL } from "node:url";
 {
     const importmeta: ImportMeta = {} as any; // Fake because we cannot really access the true `import.meta` with the current build target
     importmeta.url; // $ExpectType string
+    importmeta.resolve!("local"); // $ExpectType Promise<string>
     importmeta.resolve!("local", "/parent"); // $ExpectType Promise<string>
     importmeta.resolve!("local", new URL("https://parent.module")); // $ExpectType Promise<string>
 }
diff --git a/types/node/v18/test/module-dom.ts b/types/node/v18/test/module-dom.ts
@@ -5,5 +5,4 @@ import { URL } from "node:url";
     const importmeta: ImportMeta = {} as any; // Fake because we cannot really access the true `import.meta` with the current build target
     importmeta.url; // $ExpectType string
     importmeta.resolve!("local"); // $ExpectType Promise<string> || string
-    importmeta.resolve!("local"); // $ExpectType Promise<string> || string
 }
diff --git a/types/node/v18/test/module-non-dom.ts b/types/node/v18/test/module-non-dom.ts
@@ -4,6 +4,7 @@ import { URL } from "node:url";
 {
     const importmeta: ImportMeta = {} as any; // Fake because we cannot really access the true `import.meta` with the current build target
     importmeta.url; // $ExpectType string
+    importmeta.resolve!("local"); // $ExpectType Promise<string>
     importmeta.resolve!("local", "/parent"); // $ExpectType Promise<string>
     importmeta.resolve!("local", new URL("https://parent.module")); // $ExpectType Promise<string>
 }

Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,5 @@ import { URL } from "node:url";`
`5`	`5`	const importmeta: ImportMeta = {} as any; // Fake because we cannot really access the true `import.meta` with the current build target
`6`	`6`	`importmeta.url; // $ExpectType string`
`7`	`7`	`importmeta.resolve!("local"); // $ExpectType Promise<string> \|\| string`
`8`		`- importmeta.resolve!("local"); // $ExpectType Promise<string> \|\| string`
`9`	`8`	`}`
	`9`	`+`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ import { URL } from "node:url";`
`4`	`4`	`{`
`5`	`5`	const importmeta: ImportMeta = {} as any; // Fake because we cannot really access the true `import.meta` with the current build target
`6`	`6`	`importmeta.url; // $ExpectType string`
	`7`	`+ importmeta.resolve!("local"); // $ExpectType Promise<string>`
`7`	`8`	`importmeta.resolve!("local", "/parent"); // $ExpectType Promise<string>`
`8`	`9`	`importmeta.resolve!("local", new URL("https://parent.module")); // $ExpectType Promise<string>`
`9`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,4 @@ import { URL } from "node:url";`
`5`	`5`	const importmeta: ImportMeta = {} as any; // Fake because we cannot really access the true `import.meta` with the current build target
`6`	`6`	`importmeta.url; // $ExpectType string`
`7`	`7`	`importmeta.resolve!("local"); // $ExpectType Promise<string> \|\| string`
`8`		`- importmeta.resolve!("local"); // $ExpectType Promise<string> \|\| string`
`9`	`8`	`}`