[react] Remove Readonly<P> from class component constructor

eps1lon · eps1lon · commit d6ea30e3cdf3 · 2024-03-23T18:19:20.000+01:00
This was added in 542f3c0 without adding tests validating the behavior. It certainly doesn't work anymore since the added tests also passed with `Readonly<P>`. Maybe it did work but then the change will almost certainly be marked as working as intended. So I just remove it now since a lot of the ecosystem have inlined their own class component constructor without Readonly<P> that matches the legacy context constructur signature. Legacy context will be removed in React 19 so we would break a lot of existing code for a feature that doesn't even work.
diff --git a/types/react/index.d.ts b/types/react/index.d.ts
@@ -995,7 +995,7 @@ declare namespace React {
          */
         context: unknown;
 
-        constructor(props: Readonly<P> | P);
+        constructor(props: P);
         /**
          * @deprecated
          * @see {@link https://legacy.reactjs.org/docs/legacy-context.html React Docs}
diff --git a/types/react/ts5.0/index.d.ts b/types/react/ts5.0/index.d.ts
@@ -996,7 +996,7 @@ declare namespace React {
          */
         context: unknown;
 
-        constructor(props: Readonly<P> | P);
+        constructor(props: P);
         /**
          * @deprecated
          * @see {@link https://legacy.reactjs.org/docs/legacy-context.html React Docs}
