Service locations (Pre-logon, Always-on) #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moubctez
reviewed
Oct 23, 2025
| } | ||
|
|
||
| enum ServiceLocationMode { | ||
| SERVICE_LOCATION_MODE_UNSPECIFIED = 0; |
Contributor
There was a problem hiding this comment.
Trim SERVICE_LOCATION_MODE_?
Contributor
There was a problem hiding this comment.
While verbose this is the recommended approach for protobuf enums
j-chmielewski
previously approved these changes
Oct 23, 2025
wojcik91
previously approved these changes
Oct 23, 2025
t-aleksander
dismissed stale reviews from wojcik91 and j-chmielewski
via
302b985
wojcik91
added a commit
that referenced
this pull request
Dec 8, 2025
* Service locations (Pre-logon, Always-on) (#48) * service locations 1 * remove unused rpc * Remove superfluous CreateInterfaceRequest.allowed_ips (#49) * Basic client version reporting (#50) * client version checking 1 * add client platform info * add InterfaceConfig::mtu field (#51) * add InstanceInfo::force_all_traffic field (#52) --------- Co-authored-by: Aleksander <[email protected]> Co-authored-by: Adam <[email protected]> Co-authored-by: Jacek Chmielewski <[email protected]>
wojcik91
pushed a commit
that referenced
this pull request
Dec 8, 2025
* service locations 1 * remove unused rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1636