register code mfa methods via proxy #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moubctez
previously approved these changes
Aug 21, 2025
wojcik91
reviewed
Aug 25, 2025
| // TOTP and Email MFA Setup | ||
|
|
||
| message CodeMfaSetupStartRequest { | ||
| MfaMethod method = 1; |
Contributor
There was a problem hiding this comment.
Do we expect to ever setup other methods this way?
If not maybe we should use a different enum.
Contributor
Author
There was a problem hiding this comment.
I wanted to use common enum for this bcs protos doesn't allow to redefine enum values across same file so i couldn't make different enum with value of TOTP and Email bcs MfaMethod already have those
Contributor
Author
There was a problem hiding this comment.
this field is checked in proxy and core so I think it's fine to use it
|
|
||
| // TOTP and Email MFA Setup | ||
|
|
||
| message CodeMfaSetupStartRequest { |
Contributor
There was a problem hiding this comment.
I know why it's called CodeMfa but I think it might be confusing
Contributor
Author
There was a problem hiding this comment.
Propose better name if you can
Co-authored-by: Maciek <[email protected]>
wojcik91
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.