verify audit log events in API integration tests #1624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojcik91
changed the title
filipslezaklab
previously approved these changes
Sep 30, 2025
moubctez
reviewed
Sep 30, 2025
| { | ||
| assert_eq!( | ||
| expected_event, event, | ||
| "Event type mismatch at index {}: expected {:#?}, got {:#?}", |
Contributor
There was a problem hiding this comment.
Suggested change
| "Event type mismatch at index {}: expected {:#?}, got {:#?}", | |
| "Event type mismatch at index {index}: expected {expected_event:#?}, got {event:#?}", |
moubctez
reviewed
Sep 30, 2025
| Err(TryRecvError::Empty) => { | ||
| // Queue is empty, test passes | ||
| } | ||
| Ok(msg) => panic!("Expected empty queue, but got event: {:?}", msg), |
Contributor
There was a problem hiding this comment.
Suggested change
| Ok(msg) => panic!("Expected empty queue, but got event: {:?}", msg), | |
| Ok(msg) => panic!("Expected empty queue, but got event: {msg:?}"), |
moubctez
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tooling for asserting that expected events are being emitted in API integration tests.
Also updates some existing tests as an example.
Partially resolves #1195