refactor gRPC client version interceptor #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-chmielewski
approved these changes
Aug 28, 2025
j-chmielewski
added a commit
that referenced
this pull request
Aug 28, 2025
* fix semver version * implement proxy version check * create proxy bidi span earlier * wip check remote component version in server middleware * don't kill the bidi thread if proxy version is not supported * Revert "wip check remote component version in server middleware" This reverts commit fb34990. * wip version interceptor for server components * server does the version-check * instrument server future, remove interceptor structs * Revert "instrument server future, remove interceptor structs" This reverts commit 2acf6c9. * Revert "server does the version-check" This reverts commit e381f62. * log proxy error, better tonic error msg * return "failed precondition" if remote version is unsupported * remove unused version check function * implement relative version check for core-gateway server * cargo fmt, clippy * comments * update protos after merge * wip try to add version interceptor to mock gateway client * refactor gRPC client version interceptor (#1457) * refactor version interceptor * add version test * use postgres image from ecr.aws registry --------- Co-authored-by: Maciek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.