Add support for multiple ou in LDAP #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moubctez
reviewed
Jun 16, 2025
moubctez
reviewed
Jun 16, 2025
moubctez
reviewed
Jun 16, 2025
moubctez
reviewed
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, LDAP integration was bound only to one OU determined by the user search base, e.g.
DN: ou=users,dc=example,dc=com, making it incompatible with users which DN was nested deeper (DN: ou=some_unit,ou=users,dc=example,dc=com). This was because we didn't save the full DN and relied solely on the assumption that all user's DNs match the user search base.This PR makes Defguard save the real DN of a user and uses it for their identification.