Skip to content

Fix LDAP login #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
t-aleksander merged 3 commits into from
May 22, 2025
Merged

Fix LDAP login #1167

t-aleksander merged 3 commits into from
May 22, 2025

Conversation

@t-aleksander
Copy link
Contributor

@t-aleksander t-aleksander commented May 22, 2025 •
edited
Loading

  • adds more logs displayed during LDAP login process
  • removes some redundant checks during LDAP login which may have previously prevented some users from logging in, the user login is now accepted if the user belongs to one of the sync groups in LDAP (if defined) and is active
  • always marks user as coming from ldap if the LDAP login succeeds

@t-aleksander t-aleksander requested review from j-chmielewski, moubctez and wojcik91 and removed request for j-chmielewski and wojcik91 May 22, 2025 11:03
@t-aleksander t-aleksander merged commit 4c06628 into main May 22, 2025
4 checks passed
@t-aleksander t-aleksander deleted the fix-ldap-login branch May 22, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moubctez moubctez moubctez approved these changes

@wojcik91 wojcik91 wojcik91 approved these changes

@j-chmielewski j-chmielewski Awaiting requested review from j-chmielewski

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@t-aleksander @moubctez @wojcik91