Skip to content

Conversation

@hnnsly
Copy link
Contributor

@hnnsly hnnsly commented Dec 19, 2025

📝 New contributors

⚠︎ If the checkbox will not be confirmed - we can't include your contribution in our codebase.

📖 Description

  1. replaced create_dir with create_dir_all to handle cases where some parent directories are missing
  • I have performed manual tests manually and all changes work

Hello, maintainers,

Apologies if I've formatted this PR incorrectly, but I genuinely encountered an issue that is resolved by changing these two lines of code. Even if this PR doesn't get merged, I kindly ask you to consider making these changes, as it might help others who run into the same problem as I did.

Here is the issue I encountered

Thank you!

Changed create_dir to create_dir_all (also used across project) to avoid issue, when some parent directory is missing for ~/.local/share/net.defguard.cli
@moubctez moubctez changed the base branch from dev to main December 19, 2025 12:48
@moubctez moubctez changed the title Change create_dir to create_dir_all for default config directiroy Change create_dir to create_dir_all for default config directory creation Dec 19, 2025
@moubctez moubctez merged commit 719ea96 into DefGuard:main Dec 19, 2025
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants