Skip to content

Fixes failing tests #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
n-poulsen merged 5 commits into from
Feb 25, 2025
Merged

Fixes failing tests #2901

n-poulsen merged 5 commits into from
Feb 25, 2025

Conversation

@n-poulsen
Copy link
Contributor

@n-poulsen n-poulsen commented Feb 25, 2025

Fixes tests that were failing due to sub-optimal file naming. Checks for float and int pcutoff values. Fixes warnings raised in tests:

  • rename np.product to np.prod
  • removes unnecessary cast to torch tensor (when the returned value was already a torch tensor)

maximpavliv
maximpavliv approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@maximpavliv maximpavliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @n-poulsen !

@n-poulsen n-poulsen merged commit 59257c7 into pytorch_dlc Feb 25, 2025
1 check passed
@n-poulsen n-poulsen deleted the niels/fix_tests branch February 25, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maximpavliv maximpavliv maximpavliv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DLC3.0🔥

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@n-poulsen @maximpavliv