Skip to content

Conversation

@hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Feb 7, 2025

No description provided.

@hmaarrfk hmaarrfk closed this Feb 7, 2025
@hmaarrfk hmaarrfk reopened this Feb 7, 2025
@maximpavliv
Copy link
Contributor

I'm sorry, what is the issue your PR addresses?

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Feb 7, 2025

After you install deeplabcut 3.0 from your branch. The command dlc doesn’t because it points to

import dlc

Which doesn’t exist.

It should be
from deeplabcut.main import main

main()

which this ensures.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Feb 7, 2025

Copy link
Contributor

@maximpavliv maximpavliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you PR into main branch please? pytorch_dlc is for changes related to the pytorch backend stuff

@maximpavliv maximpavliv added Installation bug fix! fix for a real buggy one... labels Feb 10, 2025
@MMathisLab
Copy link
Member

Can you PR into main branch please? pytorch_dlc is for changes related to the pytorch backend stuff

but it seems this is for DLC3.0 ... @maximpavliv cc @n-poulsen

@hmaarrfk
Copy link
Contributor Author

I don’t think this is worth so much discussion. I’m glad I brought this one liner to your attention.

Do with it as you wish! Thanks for the cool tools!!

@MMathisLab
Copy link
Member

MMathisLab commented Feb 15, 2025

Hey @hmaarrfk sorry for this; agree it's an easy merge from my view... thank you!

Can you reopen and I'll merge

@hmaarrfk
Copy link
Contributor Author

Definitely don't be sorry. Just want to get the external contributor review process out of this decision making.

I'm likely too slow to respond to suggestions....

@MMathisLab
Copy link
Member

MMathisLab commented Feb 15, 2025

Totally understand; if you can reopen I'm on it :)

@hmaarrfk hmaarrfk reopened this Feb 15, 2025
@hmaarrfk
Copy link
Contributor Author

Feel free to push and rebase as you wish.

@MMathisLab MMathisLab merged commit 08cb7ee into DeepLabCut:pytorch_dlc Feb 15, 2025
@hmaarrfk
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix! fix for a real buggy one... DLC3.0🔥 Installation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants