-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix entrypoint for dlc #2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix entrypoint for dlc #2863
Conversation
|
I'm sorry, what is the issue your PR addresses? |
|
After you install deeplabcut 3.0 from your branch. The command dlc doesn’t because it points to import dlc Which doesn’t exist. It should be main() which this ensures. |
|
I guess you need to decide if yo uwant to point to: https://github.com/DeepLabCut/DeepLabCut/blob/main/deeplabcut/__main__.py but |
maximpavliv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you PR into main branch please? pytorch_dlc is for changes related to the pytorch backend stuff
but it seems this is for DLC3.0 ... @maximpavliv cc @n-poulsen |
|
I don’t think this is worth so much discussion. I’m glad I brought this one liner to your attention. Do with it as you wish! Thanks for the cool tools!! |
|
Hey @hmaarrfk sorry for this; agree it's an easy merge from my view... thank you! Can you reopen and I'll merge |
|
Definitely don't be sorry. Just want to get the external contributor review process out of this decision making. I'm likely too slow to respond to suggestions.... |
|
Totally understand; if you can reopen I'm on it :) |
|
Feel free to push and rebase as you wish. |
|
Thanks |
No description provided.