Dynamic update of pytorch config with dot notation #2859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-poulsen
suggested changes
Feb 4, 2025
Contributor
n-poulsen
left a comment
n-poulsen
left a comment
There was a problem hiding this comment.
Just one minor change needed - otherwise looks good to me!
maximpavliv
force-pushed
the
maxim/update_config_by_dotpath
branch
from
d05dff7 to
7ef9964
Compare
n-poulsen
suggested changes
Feb 4, 2025
Contributor
n-poulsen
left a comment
n-poulsen
left a comment
There was a problem hiding this comment.
The examples/utils.py file also needs to be updated; currently both the testscript_pytorch_single_animal.py and the testscript_pytorch_multi_animal.py fail
maximpavliv
force-pushed
the
maxim/update_config_by_dotpath
branch
from
7ef9964 to
b0229af
Compare
Contributor
Author
You're right, now I solved this! |
n-poulsen
approved these changes
Feb 5, 2025
Contributor
n-poulsen
left a comment
n-poulsen
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @maximpavliv!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this Pull Request, in order to facilitate the dynamic update of pytorch_config.yaml (when calling
deeplabcut.train_network()), I:update_config_by_dotpath()method. This method is easier to use than the previousupdate_config(). Withupdate_config(), you needed to pass a nested dictionary as argument to target nested arguments in the pytorch_config.yaml, and it wasn't explicit how the nested dict was processed. Withupdate_config_by_dotpath(), you target nested arguments by using a single-level dictionary with dot-notation path access. For example to update thegpuslist in therunnersection, you pass{"runner.gpus": [0,1]}(instead ofdict(runner=dict(gpus=[0,1])))pytorch_cfg_updates: dictargument instead of using thekwargsintrain_network().train_network()(that were passed through thekwargsbefore) for more transparency, and remove thekwargsargument fromtrain_network().update_config_by_dotpath()method, update integration tests.