Skip to content

Conversation

@n-poulsen
Copy link
Contributor

As mentioned in this comment from issue 2796, create_labeled_video fails to create a labeled video for TensorFlow single-animal projects, as it could not find the "full_data" file which is not created for such models. The content of the file was used to plot bounding boxes in the video for top-down PyTorch models.

This pull request fixes the issue by catching the FileNotFoundError when the file is not present. The functional test examples/testscript.py is updated to check that the videos have all videos have been created successfully. This updated test fails with the when the bug is in the code, and succeeds with the fix above.

@n-poulsen n-poulsen added bug fix! fix for a real buggy one... DLC3.0🔥 labels Jan 7, 2025
Copy link
Contributor

@maximpavliv maximpavliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @n-poulsen ! I think we can merge this

@n-poulsen n-poulsen merged commit ae612e0 into pytorch_dlc Jan 7, 2025
1 check passed
@n-poulsen n-poulsen deleted the niels/tf_single_animal_create_video_fix branch January 7, 2025 13:21
@maximpavliv maximpavliv mentioned this pull request Jan 8, 2025
2 tasks
@MHRosenberg
Copy link

Not fixed as far as I can tell, despite a successful pip upgrade. #2796 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix! fix for a real buggy one... DLC3.0🔥

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants