Skip to content

Conversation

@aspence
Copy link

@aspence aspence commented Dec 23, 2024

…ollectedData files that do not have split multiindex rows. no longer deletes all images instead of just the ones with no annotations. Closes #2821

…ollectedData files that do not have split multiindex rows. no longer deletes all images instead of just the ones with no annotations.
@MMathisLab MMathisLab self-requested a review December 23, 2024 16:19
@MMathisLab MMathisLab requested a review from n-poulsen January 13, 2025 21:27
@n-poulsen
Copy link
Contributor

n-poulsen commented Jan 20, 2025

Hi @aspence! Thanks for the PR, the code looks good to me! Could you just merge the most recent changes from main into your code (we pin numpy < 2) with git pull and then git merge main , as the tests currently aren't passing. Thanks!

@n-poulsen
Copy link
Contributor

Closing this PR as the changes will be made through #2850 (so the tests can be run before merging).

@n-poulsen n-poulsen closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dropimagesduetolackofannotation deletes all images when called on old CollectedData dataframes without multiindex - with fix

3 participants