Skip to content

Fix: correct the early return error when save_epochs=1 and optimize the clean up way #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
n-poulsen merged 4 commits into from
Nov 25, 2024
Merged

Fix: correct the early return error when save_epochs=1 and optimize the clean up way #2793

n-poulsen merged 4 commits into from
Nov 25, 2024
+14 −14

Conversation

@xiu-cs
Copy link
Contributor

@xiu-cs xiu-cs commented Nov 21, 2024 •
edited
Loading

  • Fixed an issue causing an incorrect early return when save_epochs=1.
  • clean up old snapshots if the number of existing snapshots exceeds the maximum allowed (executed at the end of the process).

Special thanks to @n-poulsen for your invaluable guidance! 🙏

@n-poulsen n-poulsen self-requested a review November 22, 2024 10:19
n-poulsen
n-poulsen suggested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@n-poulsen n-poulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you @xiu-cs! Just requested a few minor changes and some linting :)

@xiu-cs xiu-cs requested a review from n-poulsen November 22, 2024 15:30
@n-poulsen n-poulsen mentioned this pull request Nov 22, 2024
Merged
n-poulsen
n-poulsen approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@n-poulsen n-poulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @xiu-cs!

@n-poulsen n-poulsen merged commit 73ddd56 into DeepLabCut:pytorch_dlc Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@n-poulsen n-poulsen n-poulsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DLC3.0🔥

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xiu-cs @n-poulsen