-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Plot detector's bboxes if Top-Down architecture #2791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpavliv
commented
Nov 20, 2024
a4212ff to
e245a0b
Compare
n-poulsen
suggested changes
Nov 25, 2024
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes (mostly the mutable default argument), otherwise looks good to me!
45efa3c to
320a03f
Compare
320a03f to
84c06f7
Compare
n-poulsen
suggested changes
Dec 13, 2024
Contributor
n-poulsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo to fix but otherwise LGTM!
Co-authored-by: n-poulsen <[email protected]>
4aa0354 to
74bab25
Compare
n-poulsen
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the plotting of the detector's bounding boxes, if the architecture is Top-Down.
In particular, the bounding boxes are:
evaluate_network()when passing argumentplotting=Truecreate_video_with_all_detections(), unless passing argumentplot_bboxes=Falsecreate_labeled_video(), unless passing argumentplot_bboxes=Falsevideo_inference_superanimal(), unless passing argumentplot_bboxes=Falsevisualize_predictions(), unless passing argumentplot_bboxes=False