Use architecture-specific snapshots prefixes in video adaptation #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-poulsen
suggested changes
Nov 14, 2024
Contributor
n-poulsen
left a comment
n-poulsen
left a comment
There was a problem hiding this comment.
Looks good to me! Tiny typo to fix
maximpavliv
force-pushed
the
maxim/pseudolabels_add_model_names
branch
from
ff66012 to
3ba000f
Compare
n-poulsen
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing video adaptation with one model architecture and then re-doing with an other, video_inference_superanimal() was trying to load existing trained model with previous architecture, which resulted in a crash.
This PR uses architecture-specific prefixes to save snapshots when doing video adaptation, which resolves the issue.