Skip to content

Conversation

@n-poulsen
Copy link
Contributor

This pull request makes two bug fixes:

In deeplabcut/core/crossvalutils.py - find_closest_neighbors

  • The cKDTree.query method returns n (the size of the input data) for missing nieghbors ("Missing neighbors are indicated with self.n."). This wasn't taken into account, so this value could be returned in the index list, leading to an out-of-bounds error.

In deeplabcut/core/trackingutils.py - calc_similarity_with

  • Zero division as we didn't check the height/width of ellipses was greater than 0

@MMathisLab MMathisLab merged commit ed9492b into pytorch_dlc Aug 10, 2024
@n-poulsen n-poulsen deleted the niels/2024_08_09_bug_fixes branch August 12, 2024 07:43
Copy link
Member

@AlexEMG AlexEMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants