fix manual frame extraction with symlinks #2527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual frame extraction fails when videos are not copied to the project (as mentionned in issue #2502), as the
VideoSelectionWidgetresolves symlinks automatically. Thusnapari-deeplabcutgets a path to the video in its true location instead of the symlink, and does not extract the frames to the correct folder.This PR adds a method to check that the video is in the project folder, and gets the path to the symlink again if the path was resolved. It raises an error if the video cannot be found in the project's
videos/(e.g., if the user selected a video for manual frame extraction which was not added to the project).