Skip to content

Update setup.py #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MMathisLab merged 5 commits into from
Apr 17, 2024
Merged

Update setup.py #2526

MMathisLab merged 5 commits into from
Apr 17, 2024

Conversation

@MMathisLab
Copy link
Member

@MMathisLab MMathisLab commented Feb 19, 2024 •
edited
Loading

  • update pyside6
  • only merge after napari-deeplabcut new version is released

@MMathisLab
Update setup.py
037fa30 
- update pyside6
@MMathisLab MMathisLab requested a review from jeylau February 19, 2024 14:03
@MMathisLab
Copy link
Member Author

MMathisLab commented Mar 1, 2024

done? cc @n-poulsen

@n-poulsen
Copy link
Contributor

n-poulsen commented Mar 5, 2024

@MMathisLab I believe we need a new napari-deeplabcut release (version 0.2.1.5) including the updates made in #115 and #118 before we can merge this.

There are a few bugs with napari-deeplabcut==0.2.1.3 and pyside6==6.4.2 that have been fixed.

@MMathisLab
Copy link
Member Author

MMathisLab commented Mar 5, 2024

okay can you make a release?

n-poulsen
n-poulsen suggested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@n-poulsen n-poulsen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Python 3.10 and 3.11. I found one issue; when selecting the "Show trails" checkbox, the napari window goes blank. This is easily solved by resizing the window, but I'll open an issue about this so people have somewhere to go for a quick fix (once this PR is merged).

Otherwise all good for me once the napari-deeplabcut version is updated!

I'm also getting a warning when installing the apple_mchips extra:

WARNING: deeplabcut 2.3.9 does not provide the extra 'apple-mchips'

I believe this is the same pip issue as we saw with napari-deeplabcut (changes to the way underscores are transformed into dashes), and we can solve it by renaming the extra to apple-mchips. Currently not an issue as tensorflow is still installed correctly, despite the warning.

@MMathisLab @n-poulsen
Update setup.py
5a8eae8 
Co-authored-by: n-poulsen <[email protected]>
jeylau
jeylau reviewed Apr 3, 2024
View reviewed changes
@jeylau
Copy link
Contributor

jeylau commented Apr 3, 2024

I've just pushed a new release (0.2.1.6) of napari-deeplabcut, that includes our latest fixes/improvements.
This is ready to merge after the setup.py 😊

@MMathisLab
Copy link
Member Author

MMathisLab commented Apr 16, 2024

I guess now we can merge, or no?

@jeylau
Copy link
Contributor

jeylau commented Apr 16, 2024

@MMathisLab, yes, that looks good to me!

@MMathisLab MMathisLab merged commit bf2718a into main Apr 17, 2024
@MMathisLab MMathisLab deleted the mwm/gui branch April 17, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jeylau jeylau jeylau left review comments

@n-poulsen n-poulsen n-poulsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MMathisLab @n-poulsen @jeylau