Avoid infinite loop in mine() when there are no overlapping tracklets
#2525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeshaokai
reviewed
Feb 19, 2024
|
|
||
| def mine(self, n_samples): | ||
| if not self._lu_overlap: | ||
| raise ValueError("No overlapping tracklets found.") |
Collaborator
There was a problem hiding this comment.
Maybe add more information suggesting it's because only one animal is found from the assembly?
Contributor
Author
There was a problem hiding this comment.
We cannot be certain about it though: very sparse (bad) tracklets could also cause that. This warning if nm_animal==1 could be shown much higher up before creating a tracklet dataset. What do you think?
Collaborator
There was a problem hiding this comment.
Good point! Then I don't have other questions
yeshaokai
approved these changes
Feb 19, 2024
MMathisLab
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.