Skip to content

Test for the presence of snapshot files when using modelzoo #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexEMG merged 2 commits into from
Feb 8, 2024
Merged

Test for the presence of snapshot files when using modelzoo #2485

AlexEMG merged 2 commits into from
Feb 8, 2024

Conversation

@jeylau
Copy link
Contributor

@jeylau jeylau commented Jan 15, 2024

  • Test early whether superanimal name is a valid option
  • Test for the presence of model weight files rather than the only existence of a weight folder (so if the folder exists, but it does not contain any model snapshots, superanimal model weights will–as they should–be redownloaded, preventing the IndexError reported in other issues.)

Fixes #2469

@jeylau jeylau added the bug fix! fix for a real buggy one... label Jan 15, 2024
@Rastamous3 Rastamous3 mentioned this pull request Jan 17, 2024
Closed
2 tasks
@AlexEMG
Copy link
Member

AlexEMG commented Jan 23, 2024

Add comment here: raise ValueError(f"{superanimal_name} not available. Available ones are: ", MODELOPTIONS)

IF you see the model you want, go to the website and see what is available/upldate dlclib

AlexEMG
AlexEMG requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@AlexEMG AlexEMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update comment as outlined.

n-poulsen
n-poulsen approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@n-poulsen n-poulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AlexEMG AlexEMG merged commit a1c8f44 into main Feb 8, 2024
@MMathisLab MMathisLab mentioned this pull request Feb 8, 2024
Merged
@MMathisLab MMathisLab deleted the jeylau/superanimal_download branch February 11, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexEMG AlexEMG AlexEMG requested changes

@MMathisLab MMathisLab MMathisLab approved these changes

@yeshaokai yeshaokai Awaiting requested review from yeshaokai

+1 more reviewer

@n-poulsen n-poulsen n-poulsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug fix! fix for a real buggy one...

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IndexError: list index out of range

5 participants

@jeylau @AlexEMG @MMathisLab @n-poulsen