Skip to content

Conversation

@jesse-gilmer
Copy link
Contributor

@jesse-gilmer jesse-gilmer commented Nov 10, 2023

Hello DLC Team,

During testing of a fresh install of DLC on Ubuntu 20.04 I noticed that examples/testscript_3d.py was not completing due to various errors.

Here is a summary of the changes made:

  1. Clarification of the base directory in the code. I chose to use the 0th parent directory on line 37 and removed the reference to "examples" from line 42, but you could alternately add " config = glob.glob(os.path.join(basepath,"examples","TEST*", "config.yaml"))[-1] " as a replacement for line 104. Otherwise, line 104 will not be successful, as basepath points to /deeplabcut/, not /deeplabcut/examples/ where the config path is located.

  2. url = "http://www.vision.caltech.edu/bouguetj/calib_doc/htmls/stereo_example.zip" and its associated lines will not complete because that url does not exist any longer. The file exists (I presume this is the same file) at https://data.caltech.edu/records/jx9cx-fdh55 in calib_doc.zip at /htmls/stereo_example.zip but obviously this is not easy to access via url. I added the file to the examples folder and accessed it with "file_name = os.path.join(basepath,"stereo_example.zip")". I'm sure you will need to make some other correction that suits your project.

  3. Line 189 needs an assigned videotype to complete successfully, e.g. "deeplabcut.create_labeled_video_3d(path_config_file, [video_dir], start=5, end=10, videotype=".avi")"

I don't know git well enough to comprehend exactly what your pull request etiquette guide requires, so I hope this is sufficient. Always happy to clarify anything that is unclear.

I am tagging you for a review request per your guidelines, @MMathisLab.

All the best,
Jesse

Reconfigured pathing and dealt with bad url and videotype.
This file is no longer available for direct download, uploading here.
@MMathisLab MMathisLab requested a review from jeylau November 13, 2023 12:14
@MMathisLab MMathisLab added 3D questions/code issues regarding 3D DLC high-priority labels Apr 27, 2024
@MMathisLab MMathisLab merged commit dd0ef5a into DeepLabCut:main Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3D questions/code issues regarding 3D DLC high-priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants