Address underlying compatibility issue with scipy 1.11.0 #2396
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See warning in scipy 1.9's documentation. See warning in https://docs.scipy.org/doc/scipy-1.9.0/reference/generated/scipy.stats.mode.html The SPEC0 suggests that scipy 1.8 be dropped in 2024, but I think it is OK to drop it a little early. If you don't want to drop it, we could add a version check for the keyword argument, but that seems a little much. The keyword argument `keepdims` was added in scipy 1.9 xref: DeepLabCut#2290
MMathisLab
added
the
backwards compatibility
Member
|
NOTE: this would drop 3.7 support, but I think it's fine? 
|
Contributor
Author
|
SPEC0 (not that you are forced to support it) would even have you drop Python 3.8 and 3.9 today ;) |
jeylau
approved these changes
Oct 3, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See warning in scipy 1.9's documentation.
See warning in https://docs.scipy.org/doc/scipy-1.9.0/reference/generated/scipy.stats.mode.html
The SPEC0 suggests that scipy 1.8 be dropped in 2024, but I think it is OK to drop it a little early.
If you don't want to drop it, we could add a version check for the keyword argument, but that seems a little much.
The keyword argument
keepdimswas added in scipy 1.9xref: #2290