Remove unused parameter num_shuffles from check_for_weights function.
#2360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused num_shuffles parameter from check_for_weights().
Remove reference to num_shuffles parameter in check_for_weights() usage.
Remove reference to num_shuffles parameter in check_for_weights() usage.
Remove references to num_shuffles parameter in check_for_weights() usage and assertEqual().
Update comment containing check_for_weights() usage.
Tetra-quark
changed the title
check_for_weights function. num_shuffles from check_for_weights function.
Contributor
|
Hi @Tetra-quark, good catch! Looks all good to me, thank you very much! |
Contributor
|
Just made a minor fix directly in the PR to get the tests to pass 😊 |
Contributor
Author
|
Thanks for the fix! |
jeylau
approved these changes
Sep 11, 2023
Contributor
You're correct, these can be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
check_for_weightsfunction takes and return thenum_shufflesparameter without using it. I searched the repository, verified that it would be safe to remove and made all the alterations necessary.(I would like to contribute to the DLC repository but up till now was not super comfortable with the workflow. I thought this could be a good test for a first contribution, although small. I understand fully if the pull request is denied for reasons I have not considered.)