Avoid assembling if already done and overwrite == False #2317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This QoL significantly reduces time needed for testing different inference parameters by reading assemblies from an existing file (if already run once). Works for both identity True and False.
jeylau
suggested changes
Jul 24, 2023
MMathisLab
added
WORK IN PROGRESS!
jeylau
reviewed
Jul 27, 2023
| with open(pickle_path, "rb") as file: | ||
| data = pickle.load(file) | ||
|
|
||
| self.assemblies = {key: value for key, value in data.items() if key != "single"} |
Contributor
There was a problem hiding this comment.
self.unique = data.pop('single', {})
self.assemblies = data
Contributor
Author
There was a problem hiding this comment.
Done. A small annoyance is that it hangs a little when loading the assemblies.pickle, but I don't think this can be avoided
Contributor
There was a problem hiding this comment.
No worries! That's nothing in comparison to the time that would otherwise be spent forming the assemblies.
jeylau
reviewed
Jul 27, 2023
jeylau
reviewed
Jul 27, 2023
jeylau
previously requested changes
Jul 27, 2023
Contributor
jeylau
left a comment
jeylau
left a comment
There was a problem hiding this comment.
Just left a minor comment about ass_filename; all good otherwise!
MMathisLab
requested changes
Jul 27, 2023
Contributor
Author
|
Renamed to |
MMathisLab
approved these changes
Jul 27, 2023
Contributor
|
Looking good, thanks @KonradDanielewski! |
MMathisLab
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This QoL significantly reduces time needed for testing different inference parameters by reading assemblies from an existing file (if already run once). Works for both identity True and False.