Skip to content

Conversation

@n-poulsen
Copy link
Contributor

Addresses issue #2279.

When manually extracting outlier frames from a video (not located in the {project}/videos/ folder), two issues were occurring:

  • the video was not added to the project
  • the path to the video was given to napari-deeplabcut, instead of the path to alias (or copied video) created in the {project}/videos/ folder.

There napari-deeplabcut tried to extract the frames to a labeled-images folder located in the parent folder of the analyzed video (which logically did not exist). This pull request fixes these issues.

@n-poulsen n-poulsen requested a review from jeylau July 12, 2023 11:05
@n-poulsen n-poulsen requested a review from AlexEMG July 12, 2023 11:07
@jeylau
Copy link
Contributor

jeylau commented Jul 12, 2023

Should we pin tensorflow to <2.13 to avoid failing tests?

@n-poulsen
Copy link
Contributor Author

Should we pin tensorflow to <2.13 to avoid failing tests?

Should we do this in a separate pull request or directly here?

@jeylau
Copy link
Contributor

jeylau commented Jul 12, 2023

Should we pin tensorflow to <2.13 to avoid failing tests?

Should we do this in a separate pull request or directly here?

I'd do it separately, and merge it in main before this one.

@n-poulsen n-poulsen requested a review from jeylau July 13, 2023 06:15
@n-poulsen n-poulsen requested review from MMathisLab and removed request for AlexEMG July 14, 2023 09:42
@MMathisLab MMathisLab merged commit 8c16ecd into main Jul 15, 2023
@MMathisLab MMathisLab deleted the manual_outlier_frame_extraction_fix branch July 25, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants