Fixed draw_bbox when pyplot is in non-interactive mode #2288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-poulsen
force-pushed
the
fix_extract_frames_gui_crop
branch
from
4104181 to
7f70072
Compare
2 tasks
MMathisLab
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #2283. As documented in Matplotlib's interactive guide, show needs to be called without blocking the thread. When run in non-interactive mode, the default behavior of
show()is to block the loop until all windows are closed.Also fixes the frames being shown with the color channels in the incorrect order (
VideoReaderreturns RGB frames,imshowexpects RGB frames, and the channels were being swapped as if the frames were BGR).This fix was tested on OS X.