stitch_tracklets crashes when not enough tracks are found #2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeylau
reviewed
Jun 13, 2023
| self.G.nodes["sink"]["demand"] = incomplete_tracks | ||
| _, self.flow = nx.capacity_scaling(self.G) | ||
| paths += self.reconstruct_paths() | ||
| if len(remaining_nodes) > 0: |
Contributor
There was a problem hiding this comment.
Great! By the way, I checked, and we could also have:
if not remaining_nodes:
return
as the finally clause is executed before the function exits, no matter what.
But that's a detail 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there aren't enough tracks found by the stitcher, the current implementation fails. By running
The following error occurs as
remaining_nodesis an empty listThis PR simply returns once there are no remaining nodes, even if the number of tracks found is smaller than the desired number of tracks (as if there are no remaining nodes, no new tracks can be found). To keep the shape of the output dataframe identical to when tracks are found for all individuals, NaN-filled columns are added for the missing tracks. A user warning is printed so the user is informed that not all tracks were found: